Skip to content

fix: quoted message disappearing after editing a reply (#5665) #5745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mahibi merged 3 commits into from
Jan 23, 2026
Merged

fix: quoted message disappearing after editing a reply (#5665) #5745

mahibi merged 3 commits into from
Jan 23, 2026
+24 −1

Conversation

@kikoso
Copy link
Contributor

@kikoso kikoso commented Jan 22, 2026 •
edited
Loading

  • Update ChatActivity to correctly preserve parentMessageId during UI updates.
  • Update OfflineFirstChatRepository to restore parentMessageId from local DB if missing in server edit event.
  • Add getChatMessageEntity to ChatMessagesDao.
  • Update DummyChatMessagesDaoImpl to implement the new DAO method.

🖼️ Screenshots

🏚️ Before 🏡 After
telegram-cloud-photo-size-2-5445014385614065259-y telegram-cloud-photo-size-2-5445014385614065264-y

🚧 TODO

  • Implement database preservation logic
  • Fix UI preservation logic
  • Fix build error in Dummy DAO

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@kikoso
Fix quoted message disappearing after editing a reply (nextcloud#5665)
dfa3820 
- Update ChatActivity to correctly preserve parentMessageId during UI updates.
- Update OfflineFirstChatRepository to restore parentMessageId from local DB if missing in server edit event.
- Add getChatMessageEntity to ChatMessagesDao.
- Update DummyChatMessagesDaoImpl to implement the new DAO method.

Signed-off-by: Enrique López Mañas <eenriquelopez@gmail.com>
@kikoso kikoso force-pushed the fix/5665-quoted-message-disappearing branch from d2da79d to dfa3820 Compare January 22, 2026 15:16
@kikoso kikoso mentioned this pull request Jan 22, 2026
Closed
@kikoso
Copy link
Contributor Author

kikoso commented Jan 22, 2026

Rebased and fixed DCO.

@kikoso kikoso mentioned this pull request Jan 22, 2026
Closed
@nickvergessen nickvergessen requested a review from mahibi January 22, 2026 16:11
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: chat 🗨️ labels Jan 22, 2026
@AndyScherzinger AndyScherzinger added this to the 23.0.0 milestone Jan 22, 2026
@kikoso
Copy link
Contributor Author

kikoso commented Jan 23, 2026

@AndyScherzinger , the flows are failing due to different reasons, outside of the scope of this PR:

analysis can't run on forks.
CodeQL doesn't support Kotlin 2.3.0

@mahibi mahibi merged commit b20e722 into nextcloud:master Jan 23, 2026
13 of 16 checks passed
@mahibi
Copy link
Collaborator

mahibi commented Jan 23, 2026

works fine,
thank you @kikoso 👍

@mahibi
Copy link
Collaborator

mahibi commented Jan 23, 2026

/backport to stable-23.0

@backportbot backportbot bot mentioned this pull request Jan 23, 2026
Merged
@AndyScherzinger AndyScherzinger modified the milestones: 23.0.0, 23.1.0 Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug Something isn't working feature: chat 🗨️

Projects

None yet

Milestone

23.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@kikoso @mahibi @nickvergessen @AndyScherzinger