-
-
Notifications
You must be signed in to change notification settings - Fork 293
Refactoring search logic to use kotlin flows efficiently #5655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
…sult properly Signed-off-by: rapterjet2004 <[email protected]>
…es the activity and filtering logic, resolving race conditions Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: rapterjet2004 <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5655.apk |
sowjanyakch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Search for a keyword that appears multiple times in the message history. Messages appear, click on load more messages, instead of showing only the remaining messages, the entire search message list is displayed again from the beginning.

Followup to #5630 , see #5630 (review)
Using the recommended functional programming approach to combining and transforming flows efficiently in the conversation list view model, with new functions added to the data layer to expose the API through a flow, rather than a suspend function, which also simplifies the conversation list activity.
Todo
🏁 Checklist
/backport to stable-xx.x