Skip to content

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix Being muted blocks access to audio output settings #16631
    • Disabled state for toggle button should bring the device check dialog (as it was originally)
    • Imitate disabled appearance with no event prevention
    • In popover, hide input actions, if not allowed to enable in call, show only output

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image
image

🚧 Tasks

  • Cases, when it's allowed, but not available? - navigator.mediaDevices.getUserMedia Promise is rejected, no output devices to show anyway

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also the error state addition

@ShGKme
Copy link
Contributor

ShGKme commented Jan 5, 2026

Git I get it correctly that when there is no access, mic/video toggle (on/off) button opens the device picker?

@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 5, 2026

when there is no access, mic/video toggle (on/off) button opens the device picker?

Yes, that was the original behavior from the old times, but it was locked by 'disabled' attribute:

  • if you don't have permissions in the room, you can still set up your mic and camera where, before permissions granted to you;
  • if there's an access error... we may probably handle it better, to explain reasons to user

- e.g. revoked browser permissions or HTTP connection

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/16631/no-permissions-lock branch from ea963b7 to 0bc33e7 Compare January 7, 2026 10:10
@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 7, 2026

/backport to stable32

@Antreesy Antreesy merged commit cea7048 into main Jan 7, 2026
57 checks passed
@Antreesy Antreesy deleted the fix/16631/no-permissions-lock branch January 7, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Being muted blocks access to audio output settings

4 participants