refactor(updatenotification): remove unused notifier mock branch - #64160
Open
joshtrichards wants to merge 2 commits into
Open
refactor(updatenotification): remove unused notifier mock branch#64160joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
The test helper is only called without method overrides, so remove the unused partial-mock path and simplify its signature and return type. Signed-off-by: Josh <josh.t.richards@gmail.com>
Replace manual try/catch assertions with PHPUnit's expectException() API and split successful and exceptional cases into focused tests. Assisted-by: Copilot:gpt-5.6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
feature: install and update
feature: activity and notification
tests
joshtrichards
added
3. to review
joshtrichards
marked this pull request as ready for review
September 10, 2026 01:04
joshtrichards
requested review from
come-nc,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
September 10, 2026 01:04
come-nc
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
The test helper is only called without method overrides, so remove the unused partial-mock path and simplify its signature and return type.
Replace manual try/catch assertions with PHPUnit's expectException() API and split successful and exceptional cases into focused tests.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)