fix(shipped): stop declaring dbdoctor as a shipped app - #64157
Merged
Conversation
The DB Doctor check engine now lives in serverinfo (nextcloud/serverinfo#1123), so dbdoctor is no longer bundled with the server tarball. Leaving it in shippedApps and defaultEnabled means the server expects an app directory the release build no longer produces. The release side is nextcloud-gmbh/release-script, branch enh/unship-dbdoctor, and nextcloud-releases/server, branch fix/unship-dbdoctor. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
requested review from
Altahrim,
icewind1991,
leftybournes and
provokateurin
and removed request for
a team
September 9, 2026 20:07
blizzz
approved these changes
Sep 9, 2026
AndyScherzinger
approved these changes
Sep 9, 2026
Member
|
/backport to stable35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DB Doctor check engine moved into serverinfo (nextcloud/serverinfo#1123), so dbdoctor is not bundled with the tarball any more.
core/shipped.jsonstill lists it inshippedAppsanddefaultEnabled, which means the server declares an app directory the release build no longer produces, and tries to enable it by default.The packaging side comes out in the same pass: nextcloud-gmbh/release-script (branch
enh/unship-dbdoctor) for the legacy script and nextcloud-releases/server (branchfix/unship-dbdoctor) for the CI pipeline.nextcloud/dbdoctoritself stays alive as a standalone appstore app, this only stops it being shipped.There is no
stable35branch yet, so nothing has been released with dbdoctor declared and no backport is needed.apps/updatenotification/lib/Controller/APIController.phpnever got a dbdoctor entry, so nothing to undo there either.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)