[stable35] fix(files_sharing): normalize share target on parent folder rename - #64122
Open
backportbot[bot] wants to merge 4 commits into
Open
[stable35] fix(files_sharing): normalize share target on parent folder rename#64122backportbot[bot] wants to merge 4 commits into
backportbot[bot] wants to merge 4 commits into
Conversation
silverkszlo
marked this pull request as ready for review
September 8, 2026 14:06
silverkszlo
requested review from
Altahrim,
CarlSchwan and
leftybournes
and removed request for
a team
September 8, 2026 14:06
silverkszlo
approved these changes
Sep 8, 2026
Contributor
|
/backport to stable34 please |
Contributor
|
/backport to stable33 please |
When a recipient moved an incoming share into one of their own folders and later renamed that folder, Updater::renameChildren passed the mount point to SharedMount::moveMount. Mount points always end in a slash, and stripUserFilesPath did not normalize its result, so the slash was stored in share.file_target. PROPFIND on such a share then returns 500. Normalize the stripped path so no caller can write a trailing slash, and repair rows that are already affected. Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
perf(core): only run the trailing slash share repair once Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-opus-5 [skip ci]
Signed-off-by: silver <s.szmajduch@posteo.de>
salmart-dev
force-pushed
the
backport/63956/stable35
branch
from
September 8, 2026 15:22
c7a2616 to
0d83213
Compare
susnux
approved these changes
Sep 8, 2026
susnux
reviewed
Sep 8, 2026
| definition: 'Whether the repair step stripping trailing slashes from share targets has already been run.', | ||
| lazy: true, | ||
| ), | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
make php lint happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #63956
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.