perf: Load entries lazily again in NavigationManager - #64109
Open
come-nc wants to merge 1 commit into
Open
Conversation
come-nc
force-pushed
the
perf/navigation-manager
branch
2 times, most recently
from
September 8, 2026 08:44
6f79109 to
77ab4c2
Compare
come-nc
changed the title
come-nc
added
3. to review
There are still a few computed stuff but it should already be an improvement for code paths which are not using navigation. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
perf/navigation-manager
branch
from
September 8, 2026 15:55
5853332 to
dd063cc
Compare
come-nc
marked this pull request as ready for review
September 8, 2026 15:55
come-nc
requested review from
Altahrim,
CarlSchwan,
leftybournes and
provokateurin
and removed request for
a team
September 8, 2026 15:55
Contributor
Author
|
/backport to stable35 |
susnux
reviewed
Sep 8, 2026
| * name: string, | ||
| * app?: string, | ||
| * default?: bool, | ||
| * default: bool, |
Contributor
There was a problem hiding this comment.
Not sure this makes sense to add this to all output types (e.g. action)
susnux
reviewed
Sep 8, 2026
| /** | ||
| * @param NavigationEntry $entry | ||
| */ | ||
| private function addEntry($entry): void { |
Contributor
There was a problem hiding this comment.
I think add vs addEntry is confusing its rather something like process here 👀
| $this->addEntry($entry); | ||
| $updateDefaultEntries = true; | ||
| } catch (\Throwable $e) { | ||
| $this->logger->error('Failed to add navigation entry from closure', ['exception' => $e]); |
Contributor
There was a problem hiding this comment.
Copy Pasta
Suggested change
| $this->logger->error('Failed to add navigation entry from closure', ['exception' => $e]); | |
| $this->logger->error('Failed to add navigation entry', ['exception' => $e, 'entry' => $entry]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only trigger
LoadAdditionalEntriesEventif navigation entries are actually used.Checklist
3. to review, feature component)stable32)AI (if applicable)