fix(dav): allow moving files between subfolders of the same share - #64106
Open
Antreesy wants to merge 2 commits into
Open
fix(dav): allow moving files between subfolders of the same share#64106Antreesy wants to merge 2 commits into
Antreesy wants to merge 2 commits into
Conversation
- group folder storage doesn't implement ISharedStorage, so moves within the same team folder were rejected as cross-share moves. Compare the source's and target's enclosing shares directly instead. - add unit tests coverage in SharesPluginTest.php Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
requested review from
Altahrim,
CarlSchwan,
leftybournes and
salmart-dev
and removed request for
a team
September 7, 2026 15:27
provokateurin
requested changes
Sep 7, 2026
Comment on lines
+272
to
+279
| $sourceShares = $this->getSharesForTarget($sourceNode); | ||
| foreach ($sourceShares as $sourceShare) { | ||
| foreach ($targetShares as $targetShare) { | ||
| if ($targetShare->getId() === $sourceShare->getId()) { | ||
| return true; | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Checking it like this is very suboptimal performance wise. You can check if the destination is within the same share by just using string comparisons.
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)