fix: update last share update time when changing user status - #64023
Open
icewind1991 wants to merge 1 commit into
Open
fix: update last share update time when changing user status#64023icewind1991 wants to merge 1 commit into
icewind1991 wants to merge 1 commit into
Conversation
icewind1991
requested review from
CarlSchwan and
salmart-dev
and removed request for
a team
September 4, 2026 13:22
Member
Author
|
/backport to stable35 |
provokateurin
requested changes
Sep 4, 2026
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
unified-sharing-user-status-mtime
branch
from
September 9, 2026 16:24
a389731 to
55609a6
Compare
provokateurin
left a comment
provokateurin
left a comment
Member
There was a problem hiding this comment.
I'm actually no longer sure if we actually need this, because we don't need the timestamps to figure out which side is newer, because we know which event we're handling.
So maybe we can put this into draft for now and check later, if it is really needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We're planning on using the share modified date to coordinate syncing legacy shares, so we also need to update it when a user changes their suer status.
Checklist
3. to review, feature component)stable32)AI (if applicable)