Handle missing cached share mounts - #63501
Conversation
Fixes nextcloud#62545 by making CleanupShareTarget tolerate a missing recipient mount-cache entry during repair. The repair now skips cache removal when no cached mount exists and continues updating the share target. Signed-off-by: Oladosu Ibrahim <oladosuibrahim1999@gmail.com>
Add focused coverage for repairing a share target when the recipient’s old mount-cache entry is missing, ensuring the repair completes without dereferencing a null mount. Signed-off-by: Oladosu Ibrahim <oladosuibrahim1999@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fixes #62545
Summary
CleanupShareTargetcan encounter a missing recipient mount-cache entry while repairing a share target. The previous code dereferenced the missing entry before updating the target, causing the repair to fail. This change treats the cached mount as optional and only rewrites the cache when the entry exists, allowing the repair to continue safely.Validation
Checklist