Skip to content

fix(core): restore app menu label, show "Settings" for sub-sections#60897

Open
pringelmann wants to merge 3 commits into
masterfrom
fix/current-app-label-followups
Open

fix(core): restore app menu label, show "Settings" for sub-sections#60897
pringelmann wants to merge 3 commits into
masterfrom
fix/current-app-label-followups

Conversation

@pringelmann
Copy link
Copy Markdown
Contributor

* Resolves: #60803

## Summary

Two follow-ups from #60757.

Settings sub-section names ("Personal info", "Appearance and accessibility", ...) were too long to fit next to the centered search, which is why we hid the label below 1400px. Show "Settings" for any type === 'settings' entry instead, and restore the always-visible label at >= 1024px with the original width cap.

Preview url: https://nc-preview.tail22c02b.ts.net/

Screenshot_2026-06-01_12-44-51

The icon-centering issue (item 1 in the issue) falls out of this: the text slot is never empty while the button is visible, so the icon sits where it should.

## Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, `3. to review`, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

@pringelmann pringelmann self-assigned this Jun 1, 2026
@pringelmann pringelmann requested a review from a team as a code owner June 1, 2026 10:46
@pringelmann pringelmann requested review from nfebe, sorbaugh and susnux and removed request for a team June 1, 2026 10:47
@pringelmann pringelmann added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: apps management labels Jun 1, 2026
@pringelmann pringelmann moved this to 🏗️ At engineering in 🖍 Design team Jun 1, 2026
@pringelmann pringelmann added this to the Nextcloud 34 milestone Jun 1, 2026
@pringelmann pringelmann requested a review from kra-mo June 1, 2026 10:48
Copy link
Copy Markdown
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but would it not be possible to also just show the same generic icon for settings instead of the a11y/personal icons?

@pringelmann
Copy link
Copy Markdown
Contributor Author

Ah yes, good catch. Changed to always use settings icon instead of subsection icon

Copy link
Copy Markdown
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :) Would have also noted the icon but is already fixed, great stuff 👍

@pringelmann pringelmann force-pushed the fix/current-app-label-followups branch from f7fb246 to f535d96 Compare June 1, 2026 12:00
…gger

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann force-pushed the fix/current-app-label-followups branch from 63e6706 to 195965b Compare June 1, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. feature: apps management

Projects

Status: 🏗️ At engineering

Development

Successfully merging this pull request may close these issues.

Header redesign follow-ups (NC34 RC4)

3 participants