fix(core): restore app menu label, show "Settings" for sub-sections#60897
Open
pringelmann wants to merge 3 commits into
Open
fix(core): restore app menu label, show "Settings" for sub-sections#60897pringelmann wants to merge 3 commits into
pringelmann wants to merge 3 commits into
Conversation
kra-mo
approved these changes
Jun 1, 2026
Member
kra-mo
left a comment
There was a problem hiding this comment.
Looks good, but would it not be possible to also just show the same generic icon for settings instead of the a11y/personal icons?
Contributor
Author
|
Ah yes, good catch. Changed to always use settings icon instead of subsection icon |
jancborchardt
approved these changes
Jun 1, 2026
Member
jancborchardt
left a comment
There was a problem hiding this comment.
Looks great! :) Would have also noted the icon but is already fixed, great stuff 👍
f7fb246 to
f535d96
Compare
…gger Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
63e6706 to
195965b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
* Resolves: #60803
## Summary
Two follow-ups from #60757.
Settings sub-section names ("Personal info", "Appearance and accessibility", ...) were too long to fit next to the centered search, which is why we hid the label below 1400px. Show "Settings" for any
type === 'settings'entry instead, and restore the always-visible label at >= 1024px with the original width cap.Preview url: https://nc-preview.tail22c02b.ts.net/
The icon-centering issue (item 1 in the issue) falls out of this: the text slot is never empty while the button is visible, so the icon sits where it should.
## Checklist
stable32)