feat: delay fetching the display name of a share recipient untill we need it#58335
Open
icewind1991 wants to merge 1 commit intomasterfrom
Open
feat: delay fetching the display name of a share recipient untill we need it#58335icewind1991 wants to merge 1 commit intomasterfrom
icewind1991 wants to merge 1 commit intomasterfrom
Conversation
icewind1991
requested review from
Altahrim,
ArtificialOwl,
CarlSchwan and
come-nc
icewind1991
force-pushed
the
lazy-share-recipient-displayname
branch
from
6f412a4 to
4dbdde8
Compare
…need it Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
lazy-share-recipient-displayname
branch
from
4dbdde8 to
db4ac24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of always setting the display name in the share object, set a way to fetch the display name on demand.