Fix/setup for path optimizations#58325
Draft
salmart-dev wants to merge 5 commits intofix/mount-manager-improve-get-by-providerfrom
Draft
Fix/setup for path optimizations#58325salmart-dev wants to merge 5 commits intofix/mount-manager-improve-get-by-providerfrom
salmart-dev wants to merge 5 commits intofix/mount-manager-improve-get-by-providerfrom
Conversation
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
4987175 to
d400dd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setupForPathhas a few issues slowing things down:oc_mountstable because of the call togetMountForPathwhich is always executed unless the user or the provider have been fully set up$forChildren = falsefor paths whose parents have not been set up with children and the path is not an MP itself (because we mark the MP as setup, not the path)setupForPath('/Talk/01'),setupForPath('/Talk/02'), ...setupForPath('/Talk/100')then it would cause N+1 setupsChecklist
3. to review, feature component)stable32)