Fix a bunch of typing issues to make PHPStan level 10 happy on groupfolders#58286
Open
provokateurin wants to merge 11 commits intomasterfrom
Open
Fix a bunch of typing issues to make PHPStan level 10 happy on groupfolders#58286provokateurin wants to merge 11 commits intomasterfrom
provokateurin wants to merge 11 commits intomasterfrom
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
…s and properties Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
…ryContent Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
…yMime methods Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
Altahrim and
icewind1991
and removed request for
a team
8 tasks
CarlSchwan
reviewed
Feb 13, 2026
| <file name="3rdparty/sabre/uri/lib/functions.php"/> | ||
| </stubs> | ||
| <issueHandlers> | ||
| <InternalClass> |
Member
There was a problem hiding this comment.
I don't think we want that. internal classes are there for one reasons and we shouldn't hide the errors globaly
Member
Author
There was a problem hiding this comment.
For psalm:strict this is fine, because all those files are also covered by psalm and are added to its baseline. I don't want to have a baseline for psalm:strict and there is no way to fix them immediately, so this is the best option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, this is quite a bunch of stuff at once, but you can review commit by commit and it should be fine that way.