fix: avoid recomputing list of mounts by provider [skip ci] #58279
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmart-dev
requested review from
come-nc,
icewind1991,
leftybournes and
provokateurin
and removed request for
a team
salmart-dev
force-pushed
the
fix/mount-manager-improve-get-by-provider
branch
from
841b83e to
f4d5576
Compare
Signed-off-by: Salvatore Martire <[email protected]>
salmart-dev
force-pushed
the
fix/mount-manager-improve-get-by-provider
branch
from
f4d5576 to
4987175
Compare
|
|
||
| $mounts = []; | ||
| foreach ($mountProviders as $mountProvider) { | ||
| $mounts[] = $this->mountsByProvider[$mountProvider]; |
Member
There was a problem hiding this comment.
Suggested change
| $mounts[] = $this->mountsByProvider[$mountProvider]; | |
| $mounts[] = $this->mountsByProvider[$mountProvider] ?? []; |
Maybe just in case the provider has no mounts? Not sure if that could happen here, so your judgement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change that avoids the mount manager rebuilding the list of mounts per provider on every set up call where mounts need to be refreshed.
Before
After
Checklist
3. to review, feature component)stable32)