feat(workflowengine): Add openapi for workflow engine#58278
Open
nickvergessen wants to merge 1 commit intomasterfrom
Open
feat(workflowengine): Add openapi for workflow engine#58278nickvergessen wants to merge 1 commit intomasterfrom
nickvergessen wants to merge 1 commit intomasterfrom
Conversation
nickvergessen
requested review from
a team,
blizzz and
provokateurin
as code owners
nickvergessen
added
3. to review
nickvergessen
requested review from
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
techdebt/noid/openapi-for-workflow-engine
branch
from
5fc69c9 to
51ba71f
Compare
provokateurin
requested changes
Feb 12, 2026
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Nice, only two small things 👍
Comment on lines
+56
to
57
| /** @var list<WorkflowEngineRule> $operationsByClass */ | ||
| $operationsByClass = $this->manager->getAllOperations($this->getScopeContext()); |
Member
There was a problem hiding this comment.
Please set the return type on the method instead
Member
Author
There was a problem hiding this comment.
That does not work, actually its wrong here as well. It's only true after the format call, but didn't know where else to add it.
Member
There was a problem hiding this comment.
I think that adding the type to the return annotation of formatOperation should work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
3. to review, feature component)stable32)