fix(sharing): Prevent empty password when checkbox is enabled #58226
+336
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set passwordProtectedState explicitly when initializing shares with default passwords. This ensures the checkbox state is tracked independently of the password value, preventing it from unchecking when the password field is cleared. Also block saving new shares when password protection is enabled but no password is entered, regardless of enforcement settings. Added passWithNoTests to vitest configs to handle Vue 2/3 dual frontend test runs gracefully. Fixes: #57732, #57011 Signed-off-by: nfebe <[email protected]>
nfebe
requested review from
Altahrim,
ArtificialOwl,
leftybournes,
sorbaugh,
susnux and
szaimen
and removed request for
a team
susnux
reviewed
Feb 10, 2026
| }, | ||
| test: { | ||
| include: ['./{apps,core}/**/*.{test,spec}.?(c|m)[jt]s?(x)'], | ||
| passWithNoTests: true, |
Contributor
Author
There was a problem hiding this comment.
Prevent 1 exit when not tests around found in a linked app.
Contributor
There was a problem hiding this comment.
But in which case this should happen?
If it happens then this points to a real issue of that app.
Except you mean like external other apps you have linked only locally.
But in that case you should not put them into apps but rather something like apps-extra or similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set passwordProtectedState explicitly when initializing shares with default passwords. This ensures the checkbox state is tracked independently of the password value, preventing it from unchecking when the password field is cleared.
Also block saving new shares when password protection is enabled but no password is entered, regardless of enforcement settings.
Added passWithNoTests to vitest configs to handle Vue 2/3 dual frontend test runs gracefully.