refactor(auth): Use $request->getCookie() instead of $_COOKIE #57287
+31
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use $request->getCookie() instead of $_COOKIE directly for consistency. - Assign dependencies via variables up front for readability. - Note exceptions from each login method is possible and are not handled here / must be handled by callers. Just minor refinements to readability, maintainability, and some aspects of robustness. Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
joshtrichards
changed the title
joshtrichards
added
3. to review
joshtrichards
changed the title
joshtrichards
requested review from
Altahrim,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
solracsf
reviewed
Dec 30, 2025
Comment on lines
+1193
to
+1202
| if ( | ||
| $request->getCookie('nc_username') !== null | ||
| && $request->getCookie('nc_token') !== null | ||
| && $request->getCookie('nc_session_id') !== null | ||
| && $userSession->loginWithCookie( | ||
| $request->getCookie('nc_username'), | ||
| $request->getCookie('nc_token'), | ||
| $request->getCookie('nc_session_id') | ||
| ) | ||
| ) { |
Member
There was a problem hiding this comment.
Perhaps a more readable version?
$username = $request->getCookie('nc_username');
$token = $request->getCookie('nc_token');
$sessionId = $request->getCookie('nc_session_id');
if (
$username !== null
&& $token !== null
&& $sessionId !== null
&& $userSession->loginWithCookie($username, $token, $sessionId)
) {
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just a minor/tiny refinement for readability, maintainability, and robustness.
TODO
Checklist
3. to review, feature component)stable32)