Skip to content

refactor(trashbin): improve DAV handler robustness + docs + readability #57267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joshtrichards wants to merge 4 commits into
base: master
Choose a base branch
from
Open

refactor(trashbin): improve DAV handler robustness + docs + readability #57267

joshtrichards wants to merge 4 commits into from
+124 −104

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Dec 27, 2025 •
edited
Loading

Summary

Mostly just a refactor for code clarity/robustness restyle, but couple minor implementation tweaks:

  • check free_space against restore destination not original location
  • require a margin of safety in the free_space check (64 KiB)
  • Possible TODO item with regard to download filename encoding

TODO

  • ...

Checklist

@joshtrichards joshtrichards changed the title refactor(trashbin): restyle DAV handlers, enhance internal docs, refactor for clarity/robustness refactor(trashbin): improve robustiness+docs+readability Dec 27, 2025
@joshtrichards joshtrichards changed the title refactor(trashbin): improve robustiness+docs+readability refactor(trashbin): improve DAV handler robustness + docs + readability Dec 27, 2025
@joshtrichards joshtrichards added this to the Nextcloud 33 milestone Dec 27, 2025
@joshtrichards joshtrichards added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) feature: dav feature: trashbin labels Dec 27, 2025
@joshtrichards joshtrichards marked this pull request as ready for review December 27, 2025 05:31
@joshtrichards joshtrichards requested a review from a team as a code owner December 27, 2025 05:31
@joshtrichards joshtrichards requested review from Altahrim, leftybournes, salmart-dev and yemkareems and removed request for a team December 27, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: dav feature: trashbin ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

2 participants

@joshtrichards