Skip to content

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Dec 27, 2025

Summary

  • Reduced neste logic.
  • Moved download header logic into a helper.
  • Noted some problems with filename encoding in the current implementation (TODOs)
    • Applies to other classes; might be an opportunity create a robust shared implementation.
  • Hardened path prefix matching.
  • Added docblocks for the class and major methods.

Overall tried to make the logic more robust, readable, and maintainable.

TODO

  • ...

Checklist

@joshtrichards joshtrichards added 3. to review Waiting for reviews feature: dav feature: versions ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Dec 27, 2025
@joshtrichards joshtrichards marked this pull request as ready for review December 27, 2025 00:09
@joshtrichards joshtrichards requested a review from a team as a code owner December 27, 2025 00:09
@joshtrichards joshtrichards requested review from leftybournes, salmart-dev and sorbaugh and removed request for a team December 27, 2025 00:09
@joshtrichards joshtrichards added this to the Nextcloud 33 milestone Dec 27, 2025
@joshtrichards joshtrichards changed the title refactor(files_versions): tidy up logic and modernize class refactor(files_versions): tidy up DAV plugin logic / modernize Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: dav feature: versions ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants