test: refactor CheckerTest to drop duplicate code #57022
Draft
+239
−485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtrichards
changed the title
- Many tests use the same stubs; move them to setUp() while still supporting custom stubs/expectations within individual tests that require it - Drop the unused getAppValue stub from setUp Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Refactored tests to use createRsaAndX509 helper method for loading certificates and keys, improving code reuse and readability. Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Change expects()->method() to method() when overriding setUp() stubs to avoid PHPUnit mock expectation conflicts. Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
… test Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
joshtrichards
force-pushed
the
jtr/test-checkertest-streamline
branch
from
72ff218 to
726f5ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mimetype handling fixes/improvements
file_get_contents()stub within thetestVerifyCoreSignatureWithModifiedMimetypelistSignatureData()test that was returning a null value and passing (false negative test)willReturnCallbackforfile_get_contentsthat throws on unexpected paths — this makes missing entries fail fast and avoids accidental nullsGeneral IntegrityCheck unit tests improvements
TODO
Checklist
3. to review, feature component)stable32)