Skip to content

fix(wopi): improve robustness and error handling in getUrlSrc #5327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(wopi): improve robustness and error handling in getUrlSrc #5327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 42 additions & 10 deletions lib/WOPI/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<?php
/**
* SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors
Expand Down Expand Up @@ -31,22 +31,54 @@
}

/**
* @throws Exception
* Retrieves the urlsrc of the first action from WOPI discovery for the specified app name.
*
* @return array{urlsrc: string, action: string}
* @throws Exception if discovery XML is null, empty, malformed, or does not contain a matching action node.
*/
private function getUrlSrc(string $mimetype): array {
private function getUrlSrc(string $appName): array {
$discovery = $this->discoveryService->get();

if ($discovery === null || $discovery === '') {
$this->logger->error('WOPI::getUrlSrc - Discovery XML is null or empty');
throw new Exception('Discovery XML is null or empty');
}

$this->logger->debug('WOPI::getUrlSrc discovery: {discovery}', ['discovery' => $discovery]);

$discoveryParsed = simplexml_load_string($discovery);
if ($discoveryParsed === false) {
$this->logger->error(
'WOPI::getUrlSrc - Invalid or malformed XML in WOPI discovery response',
['discovery' => $discovery]
);
throw new Exception('Malformed XML in WOPI discovery response');
}

$result = $discoveryParsed->xpath(sprintf('/wopi-discovery/net-zone/app[@name="%s"]/action[1]', $appName));
if (empty($result)) {
$this->logger->error(
"WOPI::getUrlSrc - Could not find action for appName {appName} in this WOPI discovery response: {discovery}",
['appName' => $appName, 'discovery' => $discovery]
);
throw new Exception("Could not find action for {$appName} in WOPI discovery response");
}

$firstAction = $result[0];
$urlsrcSet = isset($firstAction['urlsrc']) && (string)$firstAction['urlsrc'] !== '';
$nameSet = isset($firstAction['name']) && (string)$firstAction['name'] !== '';

$result = $discoveryParsed->xpath(sprintf('/wopi-discovery/net-zone/app[@name=\'%s\']/action', $mimetype));
if ($result && count($result) > 0) {
return [
'urlsrc' => (string)$result[0]['urlsrc'],
'action' => (string)$result[0]['name'],
];
if (!$urlsrcSet || !$nameSet) {
$this->logger->error(
"WOPI::getUrlSrc - Found node for appName {appName}, but urlsrc and/or name are missing/empty in WOPI discovery",
['appName' => $appName, 'discovery' => $discovery]
);
throw new Exception("Found node for {$appName}, but urlsrc and/or name are missing/empty");
}

$this->logger->error('Didn\'t find urlsrc for mimetype {mimetype} in this WOPI discovery response: {discovery}', ['mimetype' => $mimetype, 'discovery' => $discovery]);
throw new Exception('Could not find urlsrc for ' . $mimetype . ' in WOPI discovery response');
return [
'urlsrc' => (string)$firstAction['urlsrc'],
'action' => (string)$firstAction['name'],
];
}
}
Loading