fix(CapabilitiesService): fix typo causing custom productName to be ignored#5321
Open
joshtrichards wants to merge 1 commit intomainfrom
Open
fix(CapabilitiesService): fix typo causing custom productName to be ignored#5321joshtrichards wants to merge 1 commit intomainfrom
joshtrichards wants to merge 1 commit intomainfrom
Conversation
…gnored Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
juliusknorr
reviewed
Feb 18, 2026
Comment on lines
+108
to
+109
| if (isset($this->capabilities['productName']) && $theme !== 'nextcloud') { | ||
| return $this->capabilities['productName']; |
Member
There was a problem hiding this comment.
Thanks this is a good catch. One small addition:
Suggested change
| if (isset($this->capabilities['productName']) && $theme !== 'nextcloud') { | |
| return $this->capabilities['productName']; | |
| if (isset($this->getCapabilities()['productName']) && $theme !== 'nextcloud') { | |
| return $this->getCapabilities()['productName']; |
To be in line with the rest and also cover it in case it is the first method is called
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Don't see a bug report for this, but it's a bug.
TODO
Checklist