fix: sorting of items in "Mail settings" dialog#13171
Open
madbob wants to merge 1 commit into
Open
Conversation
Member
|
Thank you! This will be reviewed and tested shortly |
Member
|
/backport to stable5.10 |
GretaD
approved these changes
Jun 29, 2026
Contributor
There was a problem hiding this comment.
tested and works well.
From a readability standpoint, it might be more logical to move it into messages near its trigger (@click="() => textBlockDialogOpen) or keep it as a direct child of NcAppSettingsDialog outside all sections instead of in the appearance section. But both work well.
Approving so its not blocked
Contributor
|
Please also, make sure you sign the commit |
Signed-off-by: Roberto Guido <info@madbob.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, just an issue in the order of
NcAppSettingsSectiontags opening and closing.Fixes #12211