Skip to content

fix(sieve): fix handling of empty existing sieve scripts#13100

Open
hazveg wants to merge 1 commit into
nextcloud:mainfrom
hazveg:fix/empty-existing-sieve-script-handling
Open

fix(sieve): fix handling of empty existing sieve scripts#13100
hazveg wants to merge 1 commit into
nextcloud:mainfrom
hazveg:fix/empty-existing-sieve-script-handling

Conversation

@hazveg

@hazveg hazveg commented Jun 17, 2026

Copy link
Copy Markdown

This patch implements a check to more cleanly handle the case where the user's existing Sieve script is empty.
This occurs in the following two cases (from what I've tested):

  • User cleared the contents in the Sieve script editor manually
  • The Sieve script files on the server were deleted otherwise

This issue was first encountered when I implemented the redirect action in #13095 (See blank line at start of built script).

blank line uptop

I must presume this wasn't an issue before now because every other implemented action in the Filter UI also needed to import something, somehow causing that empty string in $lines to disappear. Debugging via Exceptions shows that an empty script file leads to a blank string at the start of $lines:

Before

empty string

After

after

Signed-off-by: hazveg <aaron.jaeger06@gmail.com>
@welcome

welcome Bot commented Jun 17, 2026

Copy link
Copy Markdown

Thanks for opening your first pull request in this repository! ✌️

@ChristophWurst

Copy link
Copy Markdown
Member

Thank you for the fix! I'll let Sieve engineer @kesselb handle this one :)

@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable5.9

@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable5.10

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants