fix(sieve): fix handling of empty existing sieve scripts#13100
Conversation
Signed-off-by: hazveg <aaron.jaeger06@gmail.com>
|
Thanks for opening your first pull request in this repository! ✌️ |
|
Thank you for the fix! I'll let Sieve engineer @kesselb handle this one :) |
|
/backport to stable5.9 |
|
/backport to stable5.10 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This patch implements a check to more cleanly handle the case where the user's existing Sieve script is empty.
This occurs in the following two cases (from what I've tested):
This issue was first encountered when I implemented the redirect action in #13095 (See blank line at start of built script).
I must presume this wasn't an issue before now because every other implemented action in the Filter UI also needed to import something, somehow causing that empty string in
$linesto disappear. Debugging via Exceptions shows that an empty script file leads to a blank string at the start of$lines: