refactor: split sso settings form #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saw-jan
force-pushed
the
refactor/split-oauth-settings-form
branch
3 times, most recently
from
2df51c0 to
23b6948
Compare
saw-jan
requested review from
Kharonus,
NobodysNightmare,
ba1ash,
dominic-braeunlein,
individual-it,
julien-nc,
lindenthal,
nabim777,
psatyal and
wielinde
as code owners
saw-jan
force-pushed
the
refactor/split-oauth-settings-form
branch
from
23b6948 to
4108afc
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Collaborator
|
LGTM 👍🏻 |
saw-jan
force-pushed
the
refactor/split-oauth-settings-form
branch
from
4108afc to
ad73a7c
Compare
Collaborator
individual-it
left a comment
individual-it
left a comment
There was a problem hiding this comment.
I think some tests still need to be fixed
saw-jan
force-pushed
the
refactor/split-oauth-settings-form
branch
from
ad73a7c to
7f21307
Compare
saw-jan
force-pushed
the
refactor/split-oauth-settings-form
branch
from
7f21307 to
0fcd231
Compare
Signed-off-by: Saw-jan <[email protected]>
Signed-off-by: Saw-jan <[email protected]> fix: remove form stepper Signed-off-by: Saw-jan <[email protected]>
Signed-off-by: Saw-jan <[email protected]>
Signed-off-by: Saw-jan <[email protected]> fix: consistent styles Signed-off-by: Saw-jan <[email protected]>
saw-jan
force-pushed
the
refactor/split-oauth-settings-form
branch
from
0fcd231 to
180afa0
Compare
nabim777
approved these changes
Dec 24, 2025
PHP Code CoverageCoverage after merging refactor/split-oauth-settings-form into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate SSO settings form from the Admin component.
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile