Repository navigation
chore(deps): keep the unused vite 8 copy out of the lock file - #155
Merged
Merged
Conversation
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
oleksandr-nc
changed the title
oleksandr-nc
force-pushed
the
chore/npm-lock-refresh
branch
from
October 23, 2026 09:05
a02b2e6 to
104b7fb
Compare
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vue-router, which@nextcloud/vuedepends on, lists vite^7.3.0 || ^8.0.0as an optional peer. The app builds with vite 6, so the lock file carries a separate vite 8.3.4 for that peer under@nextcloud/vue, with the esbuild 0.28.2, rolldown 1.2.14 and lightningcss 1.33.0 it brings and their platform packages: 59 entries. The build never uses that copy. npm 11.11.0, the lowest npmenginesallows and the one Dependabot runs since #154, still installs part of it onnpm ci; later npm leaves it out, and any npm from 11.11 on drops it when it writes the lock file.Dropping the copy alone does not give a stable lock: with this tree npm 11.11 to 11.17 mark vite, esbuild and esbuild's platform packages as not only for development, while npm 11.18 and later mark them dev-only, so every lock file change by Dependabot or by a newer npm would flip those 28 entries. With an override that sets every vite to the app's own (
"vite": "$vite"), npm 11.11 to 11.21 write the same lock. Apart from the removed entries, onlydevanddevOptionalflags change; no package changes version.🤖 AI (if applicable)