fix: avoid vsprintf ValueError in non-English notification locales#168
Merged
Conversation
Use %n for the plural counter instead of %s in the "new open tickets" message. With %s, Nextcloud's L10N pipeline never passes %count% to Symfony's IdentityTranslator, so the imploded "singular|plural" translation is returned verbatim and vsprintf trips on the extra %s placeholders, breaking the notifications API and mail cron for every non-English user. Same bug pattern as nextcloud/integration_github#197. Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Notifier::prepare()fornew_open_tickets, the plural message used%sas the counter placeholder. With%s, Nextcloud's L10N pipeline never sets%count%for Symfony'sIdentityTranslator, so the imploded"singular|plural"translation is returned verbatim andvsprintfthen trips on the extra%s— throwingValueErrorfor every non-English user and breaking the notifications API and mail cron until the rows are deleted from the DB.Switching the counter to
%n(the Nextcloud convention) lets the L10N layer pass%count%and pick the correct plural form before substitution.Same bug pattern and fix as nextcloud/integration_github#197 / nextcloud/integration_github#203.