Skip to content

fix: file share - #3522

Merged
samin-z merged 2 commits into
mainfrom
fix/delete-form-fileshares
Jul 21, 2026
Merged

fix: file share#3522
samin-z merged 2 commits into
mainfrom
fix/delete-form-fileshares

Conversation

@samin-z

@samin-z samin-z commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

🤖 AI (if applicable)

  • [-] The content of this PR was partly or fully generated using AI

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z
samin-z force-pushed the fix/delete-form-fileshares branch from 4acf9ae to 08f03dd Compare July 20, 2026 13:26
@Chartman123 Chartman123 added bug Something isn't working 2. developing Work in progress feature: 👥 sharing settings labels Jul 21, 2026
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
@samin-z
samin-z force-pushed the fix/delete-form-fileshares branch from 1d7c980 to c3617d0 Compare July 21, 2026 07:16
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Service/UploadedFilesShareService.php 75.00% 5 Missing ⚠️
lib/Controller/ShareApiController.php 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Chartman123 Chartman123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell.

Should we add a repair step to cleanup left-overs?

@samin-z
samin-z merged commit 8f9d7dc into main Jul 21, 2026
54 checks passed
@samin-z
samin-z deleted the fix/delete-form-fileshares branch July 21, 2026 07:33
@Chartman123

Copy link
Copy Markdown
Collaborator

/backport to stable5.3

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Jul 21, 2026
@backportbot backportbot Bot mentioned this pull request Jul 21, 2026
3 tasks
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress bug Something isn't working feature: 👥 sharing settings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants