-
Notifications
You must be signed in to change notification settings - Fork 2.1k
rename title from "Encryption configuration" to "Server-Side Encrypti… #13387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…on configuration" we also have e2ee, which is not covered here, so I feel the title needs to be more specific Signed-off-by: Alexander Müller <[email protected]>
Then you have other parts as well: not sure if then the file names and menu items should be updated as well? |
Yes IMO we should also rename the titles of the other pages, and all file names. Do you agree that this makes sense? |
@alexanderdd Will you adapt the other mentioned files in your branch as well? |
related to #13387 Signed-off-by: Alexander Müller <[email protected]>
related to #13387 Signed-off-by: Alexander Müller <[email protected]>
@rakekniven I don't know how to include those changes here in this PR, it was easier/faster for me to create separate PRs: Can you approve those PRs, and this PR here? AFAIK the Menu entries are generated from the titles of the documents (not the *.rst file names), so those should be updated automatically to "Server-Side encryption". |
======================== | ||
==================================== | ||
Server-Side Encryption configuration | ||
==================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Server-Side Encryption details -> Server-side encryption details
See my requests for tiny adaptions. As soon as you apply them I will approve and merge them. |
related to #13387 Signed-off-by: Alexander Müller <[email protected]>
…on configuration"
we also have e2ee, which is not covered here, so I feel the title needs to be more specific