fix(tray): match menu icons to palette - #10703
Open
Rello wants to merge 7 commits into
Open
Conversation
Collaborator
|
works fine apart from the pause icon |
mgallien
force-pushed
the
codex/fix-windows-tray-dark-icons
branch
from
September 1, 2026 07:17
9d2e353 to
e24d4bf
Compare
mgallien
approved these changes
Sep 1, 2026
mgallien
marked this pull request as ready for review
September 1, 2026 07:18
mgallien
requested review from
camilasan,
claucambra,
i2h3 and
nilsding
as code owners
September 1, 2026 07:18
mgallien
enabled auto-merge
September 1, 2026 07:18
mgallien
approved these changes
Sep 1, 2026
Collaborator
Author
|
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10703.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
mgallien
force-pushed
the
codex/fix-windows-tray-dark-icons
branch
from
September 2, 2026 12:36
386044d to
2655cf5
Compare
Use the menu's effective palette when tinting template icons so root and account submenu actions follow dark mode. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
Use the template-compatible pause and sync glyphs so palette tinting preserves their shapes. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
Register the statically linked resource collections before constructing the tray menu in SystraySyncControlQtTest. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
Add unbranded pause and play action glyphs and tint them through the same menu-palette path as the other tray actions. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
Treat multiple uninitialized sync folders as waiting to start so the global tray icon and Windows tooltip agree with the account indicators. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
Check that tray icons contain the requested menu-palette color without requiring every opaque platform-rendered pixel to match it. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
Expose the native tray icon palette selector and test its returned active text color without depending on platform QIcon rasterization. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5
mgallien
force-pushed
the
codex/fix-windows-tray-dark-icons
branch
from
September 7, 2026 07:21
2655cf5 to
7abbb6f
Compare
|
Collaborator
Author
|
/backport to stable-34.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the menu's effective palette when tinting template icons so root and account submenu actions follow dark mode.
Assisted-by: Codex:GPT-5