Skip to content

Use title case for context menu entries on macOS and Linux - #10581

Open
xhon-pelushi wants to merge 1 commit into
nextcloud:masterfrom
xhon-pelushi:fix/title-case-context-menu-10525
Open

Use title case for context menu entries on macOS and Linux#10581
xhon-pelushi wants to merge 1 commit into
nextcloud:masterfrom
xhon-pelushi:fix/title-case-context-menu-10525

Conversation

@xhon-pelushi

Copy link
Copy Markdown
Contributor

Summary

  • Use title case for shell/Finder context menu labels on macOS and Linux (Lock File, Share Options, Open in Browser, Copy Internal Link, File Actions).
  • Keep Windows sentence case via Q_OS_WIN helpers.
  • Title-case Mac File Provider "Always Keep Downloaded" and Linux/macOS VFS pin/free-space actions.

Fixes #10525

Test plan

  • On Linux: open a synced file context menu and confirm title-cased labels.
  • On Windows: confirm sentence case is unchanged.
  • On macOS File Provider: confirm "Always Keep Downloaded" label.

Match platform HIG capitalization for Finder/Files context menu and
Quick Actions labels on macOS and Linux, while keeping Windows
sentence case. Covers the socket API context menu (share, lock/unlock,
open in browser, copy internal link), VFS pin/free-space actions, the
macOS File Provider extension's "Always Keep Downloaded" action, and
the Linux GNOME cloud providers menu.

Fixes nextcloud#10525

Signed-off-by: xhon-pelushi <xhon@pelushi.com>
@xhon-pelushi
xhon-pelushi force-pushed the fix/title-case-context-menu-10525 branch from 78ff18b to d98c456 Compare August 12, 2026 05:00
@Rello Rello added this to the 35.0.0 milestone Aug 12, 2026
@Rello

Rello commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

we need to check the translation system to be still working.
as translators need to adjust the strings in transifex, this should not be merged shortly before a release

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@i2h3

i2h3 commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Overall, it looks fine to me. However, I do not know how the different casing in the keys of the localizable strings work out during the lookup (could be evaluated in a manual test of development builds on the different platforms). I mean the Qt code, the file provider is approved by me as it is. And also: does Transifex support different translation keys which differ only in casing? 😵‍💫

@Rello

Rello commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

@rakekniven
Hi,
can you check the recent comment? do you see an issue with the translations?

@rakekniven

Copy link
Copy Markdown
Member

Even after reading it twice, I still haven’t understood the reason for this change?

Over the last few years, we have changed a great many strings as follows:
"Form Title" -> "Form title"
"FORM TITLE" -> "Form title"
"FormTitle" -> "Form title"

Request for clarification.

And also: does Transifex support different translation keys which differ only in casing?

Unfortunately yes, it does. Translators often ask why we have several strings for different capitalisation. We have therefore gone to the expense of standardising the strings.

@i2h3

i2h3 commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

@rakekniven The Nextcloud guidelines conflict with user experience and expectations on Apple devices at our own cost. Based on my experience, platform conventions always beat product conventions. Especially on Apple devices, where users have the highest expectation for consistency compared to the others. Simply put: not following the casing which is present everywhere in the surrounding user interface sticks out negatively and looks unprofessional. I assume that end users will not care for our reasoning and justification in that context but just consider our product badly maintained or not conveying the feeling of being made for the platform beyond an alibi.

To be consistent with platform experiences, use title-style capitalization. Although a game might have a different writing style, generally prefer using title-style capitalization, which capitalizes every word except articles, coordinating conjunctions, and short prepositions, and capitalizes the last word in the label, regardless of the part of speech. For complete guidance on this style of capitalization in English, see title-style capitalization.

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use title case for context menu entries on macOS and Linux

4 participants