Use title case for context menu entries on macOS and Linux - #10581
Use title case for context menu entries on macOS and Linux#10581xhon-pelushi wants to merge 1 commit into
Conversation
Match platform HIG capitalization for Finder/Files context menu and Quick Actions labels on macOS and Linux, while keeping Windows sentence case. Covers the socket API context menu (share, lock/unlock, open in browser, copy internal link), VFS pin/free-space actions, the macOS File Provider extension's "Always Keep Downloaded" action, and the Linux GNOME cloud providers menu. Fixes nextcloud#10525 Signed-off-by: xhon-pelushi <xhon@pelushi.com>
78ff18b to
d98c456
Compare
|
we need to check the translation system to be still working. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Overall, it looks fine to me. However, I do not know how the different casing in the keys of the localizable strings work out during the lookup (could be evaluated in a manual test of development builds on the different platforms). I mean the Qt code, the file provider is approved by me as it is. And also: does Transifex support different translation keys which differ only in casing? 😵💫 |
|
@rakekniven |
|
Even after reading it twice, I still haven’t understood the reason for this change? Over the last few years, we have changed a great many strings as follows: Request for clarification.
Unfortunately yes, it does. Translators often ask why we have several strings for different capitalisation. We have therefore gone to the expense of standardising the strings. |
|
@rakekniven The Nextcloud guidelines conflict with user experience and expectations on Apple devices at our own cost. Based on my experience, platform conventions always beat product conventions. Especially on Apple devices, where users have the highest expectation for consistency compared to the others. Simply put: not following the casing which is present everywhere in the surrounding user interface sticks out negatively and looks unprofessional. I assume that end users will not care for our reasoning and justification in that context but just consider our product badly maintained or not conveying the feeling of being made for the platform beyond an alibi.
References |
Summary
Q_OS_WINhelpers.Fixes #10525
Test plan