fix(folderwatcher): ignore events for stale inotify watch descriptors#10389
fix(folderwatcher): ignore events for stale inotify watch descriptors#10389thstyl2000 wants to merge 2 commits into
Conversation
nilsding
left a comment
nilsding
left a comment
There was a problem hiding this comment.
good catch, thanks! one note though about the test:
c07d340 to
8fb2086
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fb20863fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
You are welcome! It was not sth i could really avoid "not catching", the laptop was brought seriously on its knees.... Thanks for replying so quickly! |
claucambra
left a comment
claucambra
left a comment
There was a problem hiding this comment.
Just a couple of nitpicks!
dce19a5 to
104f352
Compare
|
@nilsding @claucambra Squashed the commits to get the one test passing, now it needs another approval, sorry! |
|
Artifact containing the AppImage: nextcloud-appimage-pr-10389.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
@nilsding @claucambra sorry once more, I thought updating branch was harmless, and now you need to approve again..... ...not touching anything here myself again unless you tell me to! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9305639411
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Assisted-by: Codex:GPT-5 Co-authored-by: Claudio Cambra <developer@claudiocambra.com> Signed-off-by: thstyl2000 <18458458+thstyl2000@users.noreply.github.com>
81e185f to
e6dfc8b
Compare
...lied (addressed codex review) |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
3 participants
Summary
The desktop client (linux) may escape the watched folders and starts iterating on the root partition. This happens almost certainly, when for example working with codex-cli: codex writes and deletes files relatively fast, so an added watcher resolves into "/" and nextcloud starts iterating from there.
A bit more precise:
What this PR implements:
TODO
Checklist
Uploaded screenshots from before and after for UI changes.Backports requested where applicable (critical bugfixes).AI (if applicable)