Skip to content

feat: refactor activity window into own folder structure#10350

Open
Rello wants to merge 2 commits into
masterfrom
feature/activityRefactor
Open

feat: refactor activity window into own folder structure#10350
Rello wants to merge 2 commits into
masterfrom
feature/activityRefactor

Conversation

@Rello

@Rello Rello commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Implemented the Search-style activity modularization.

  • Moved activity QML and C++ support into src/gui/activity/ and src/gui/activity/qml/.
  • Updated resources, CMake, imports, and external include paths.
  • Activities window now receives account data, activity model, and sync-status model from Systray, rather than accessing UserModel from QML.
  • Moved chat replies into ActivityListModel, removing the User-model reply bridge.
  • Added account-based sync-status loading for the standalone window.

@Rello Rello self-assigned this Jul 10, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 266bca3edf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/gui/activity/qml/ActivitiesWindow.qml
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
47.1% Coverage on New Code (required ≥ 80%)
141 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

@Rello

Rello commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Done — merged origin/master into the branch. Git auto-resolved all conflicts cleanly (resources.qrc, CMakeLists.txt, activitylistmodel.cpp, owncloudgui.cpp, systray.cpp). The merge commit is c2a23ed.

Copilot finished work on behalf of Rello July 14, 2026 11:54
Rello added 2 commits July 17, 2026 09:20
Signed-off-by: Rello <github@scherello.de>
…ned SyncStatusSummary before showing it.

Signed-off-by: Rello <github@scherello.de>
@mgallien
mgallien force-pushed the feature/activityRefactor branch from c2a23ed to 1910cdb Compare July 17, 2026 07:20
@mgallien
mgallien requested a review from claucambra as a code owner July 17, 2026 07:20
@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10350.zip

Digest: sha256:466d49bd02a42aa4f2da394aec6482baaa5e30a62485cab6c873f5144e3867b5

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants