feat(e2ee): add a way to trigger a reupload of encryption metadata#10286
feat(e2ee): add a way to trigger a reupload of encryption metadata#10286mgallien wants to merge 5 commits into
Conversation
ca34b1e to
0b35fd3
Compare
e8539b0 to
33662af
Compare
nilsding
left a comment
nilsding
left a comment
There was a problem hiding this comment.
some smaller comments, looks fine overall so far
|
|
||
| QString RepairFolderEncryptionMetadataJob::errorString() const | ||
| { | ||
| return _errorString; |
There was a problem hiding this comment.
the _errorString is never modified, not sure if this is intentional
what happens when uploading the repaired metadata failed?
d5fe971 to
8c5d391
Compare
clazy can checks for data types involved in MOC code to be fully qualified fix all issues reported Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we may need to unlock encrypted folders to do it, encryption must be in a working stae: skip it if encryption is not ready Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
8c5d391 to
33544be
Compare
if encryption metadata are broken, upload a new version of the metadata built from local state to repair access to files and be able to work again with it Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
to do proper data recovery for the encryption metadata, use local information to rebuild an as correct as possible view of the encrypted folder use that information to generate a new metadata from scratch Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
33544be to
22c8b60
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-10286.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
2 participants
if encryption metadata are broken, upload a new version of the metadata built from local state to repair access to files and be able to work again with it
Resolves
#
Summary
TODO
Checklist
AI (if applicable)