fix: add new tags to card and board #7508
Open
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Brilliant, this looks like a clean and simple solution! Thank you! |
Signed-off-by: grnd-alt <[email protected]>
grnd-alt
force-pushed
the
fix/6680-adding-a-new-tag-to-a-card-has-unexpected-behaviour
branch
from
3517c81 to
41cb63f
Compare
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
grnd-alt
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Office team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Thanks to @theoholl for coming up with a contribution.
This is a simpler fix, to not over complicate the card store logic.
We should think about some refinements to the way labels are added in the frontend in general though.
(we have no description at all on what kind of props 'addLabel' requires e.g.)
Checklist