feat: show attachments only in view mode for simple editor #7819
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavohri
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
Contributor
Author
|
Should attachments be visible during editing in simple editor, or hidden completely as they are now? |
Contributor
|
Hi @abhinavohri Thank you for the PR. But this change will need approval from the design team. |
Contributor
|
What are your thoughts on this change? My only comment would be maybe we should make the attachments section collapsible? or list them horizontally instead of vertically to save space. |
SebastianKrupinski
added
3. to review
Signed-off-by: Abhinav Ohri <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #7816
Summary:
This PR aims to show attachment list in the simple editor in viewing mode.
Before:
After:
