Skip to content

Feature to remove already uploaded files in autoupload folders to free up space on the device - #17516

Merged
alperozturk96 merged 33 commits into
masterfrom
feature/1475-delete-uploaded-files
Sep 3, 2026
Merged

Feature to remove already uploaded files in autoupload folders to free up space on the device#17516
alperozturk96 merged 33 commits into
masterfrom
feature/1475-delete-uploaded-files

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Fix https://github.com/nextcloud-gmbh/customer-feature-requests/issues/1475

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image
(did not exist) image
(did not exist) image
(did not exist) image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32750778139/artifacts/9529280875
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/32851799446/artifacts/9566752145
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@daniele-verducci
daniele-verducci force-pushed the feature/1475-delete-uploaded-files branch from bf25c8a to 6110dac Compare August 27, 2026 15:26
@daniele-verducci
daniele-verducci marked this pull request as ready for review August 27, 2026 15:28
@daniele-verducci daniele-verducci added this to the Nextcloud App 35.0.0 milestone Aug 27, 2026
@daniele-verducci daniele-verducci changed the title Feature/1475 delete uploaded files Implemented feature to remove already uploaded files in autoupload folders to free up space on the device Aug 27, 2026
@daniele-verducci daniele-verducci changed the title Implemented feature to remove already uploaded files in autoupload folders to free up space on the device Feature to remove already uploaded files in autoupload folders to free up space on the device Aug 27, 2026
@daniele-verducci

Copy link
Copy Markdown
Contributor Author

Hey @kra-mo , for the design part, I user what was already there. Can you please have a look at it? In particular the last screen (the completion notification) is probably too cluttered... What do you think?

@kra-mo

kra-mo commented Aug 28, 2026

Copy link
Copy Markdown
Member

Right, I mean the notification does probably have a lot of unnecessary info. The time it took and the files left in place could be removed.

The wording for the rest makes sense, with the one comment that Auto Upload is not a brand name, as far as I'm aware, so it should be lowercase (just "auto upload") in the first screen.

@kra-mo

kra-mo commented Aug 28, 2026

Copy link
Copy Markdown
Member

Right, and also it should be "free up space on the device", not "in the device".

@kra-mo

kra-mo commented Aug 28, 2026

Copy link
Copy Markdown
Member

Right, and also, on the fourth screen, it's just spelled "autoupload", but it should be two words, "auto upload"

@daniele-verducci

Copy link
Copy Markdown
Contributor Author

Thank you Laura! I made the changes

@github-actions

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/33377822494/artifacts/9752779534
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@daniele-verducci
daniele-verducci force-pushed the feature/1475-delete-uploaded-files branch from 29bd623 to dc5dd34 Compare September 1, 2026 10:17
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/33496671315/artifacts/9799498526
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 force-pushed the feature/1475-delete-uploaded-files branch from dc5dd34 to a1c23ff Compare September 2, 2026 08:17
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/33607965074/artifacts/9839125169
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@nextcloud nextcloud deleted a comment from github-actions Bot Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/33618250055/artifacts/9843097961
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/33622526425/artifacts/9845810333
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 force-pushed the feature/1475-delete-uploaded-files branch from f4f34a6 to c7f775f Compare September 2, 2026 12:54
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…lename

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
daniele-verducci and others added 22 commits September 3, 2026 08:59
…und worker

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>

# Conflicts:
#	app/src/main/res/values/strings.xml
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…s, added users in report

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…ictures uploaded before enabling subfolders by date

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…pletion notification

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…neered formatting function

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…reamlined flow

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the feature/1475-delete-uploaded-files branch from c7f775f to 66e1f00 Compare September 3, 2026 06:59
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness5858
Dodgy code202202
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3737
Security1919
Total380380

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/33730107158/artifacts/9884433457
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 merged commit 2affe52 into master Sep 3, 2026
18 of 22 checks passed
@alperozturk96
alperozturk96 deleted the feature/1475-delete-uploaded-files branch September 3, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants