Apppassword onetime #16166
Open
Apppassword onetime #16166
+45
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tobiasKaminsky
commented
Dec 18, 2025
tobiasKaminsky
commented
- Tests written, or not not needed
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
tobiasKaminsky
force-pushed
the
apppassword-onetime
branch
from
2c4833e to
3c541e2
Compare
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16166.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
ZetaTom
reviewed
Jan 8, 2026
Collaborator
ZetaTom
left a comment
ZetaTom
left a comment
There was a problem hiding this comment.
Works fine. Commented on a minor nitpick to further improve UX.
| webViewPassword = otpResult.getResultData(); | ||
|
|
||
| runOnUiThread(this::checkOcServer); | ||
| } else { |
Collaborator
There was a problem hiding this comment.
From a UX perspective, checking for 401 Unauthorized and showing a better fitting error message may be worth it. This should only happen when the scanned code has expired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.