Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

We use KAPT only for creating language for MarkwonGrammarLocator.
I now replaced it with pre-built version.

This saves on my machen 20s per each full run.

  • Tests written, or not not needed

false,
"property",
grammar("inside",
token("string", pattern(compile("(#\\s*include\\s*)(?:<.+?>|(\"|')(?:\\\\?.)+?\\2)"), true)),

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '#include"' and containing many repetitions of '\\a'.
token(
"template-string",
pattern(
compile("`(?:\\\\[\\s\\S]|\\$\\{[^}]+\\}|[^\\\\`])*`"),

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '`' and containing many repetitions of '${{\[}}'.
GrammarUtils.require(prism4j, "clike"),
"swift",
token("string", pattern(
compile("(\"|')(\\\\(?:\\((?:[^()]|\\([^)]+\\))+\\)|\\r\\n|[\\s\\S])|(?!\\1)[^\\\\\\r\\n])*\\1"),

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '"\\' and containing many repetitions of '(')\\'.
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added files currently ship the template SPDX header. Should update the copyright line on them.

@tobiasKaminsky
Copy link
Member Author

Added files currently ship the template SPDX header. Should update the copyright line on them.

Done. Changed to their license as stated here: https://github.com/noties/Prism4j/blob/master/README.md#license

Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code257257
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4444
Security1818
Total481481

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16018.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants