Handle user disabled exception as its own result code #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZetaTom
previously approved these changes
Oct 12, 2023
alperozturk96
previously approved these changes
Nov 10, 2023
AndyScherzinger
dismissed stale reviews from alperozturk96 and ZetaTom
via
29df43f
AndyScherzinger
force-pushed
the
disabled
branch
from
c30fb8e to
29df43f
Compare
alperozturk96
previously approved these changes
Nov 10, 2023
tobiasKaminsky
force-pushed
the
disabled
branch
from
29df43f to
acd94f3
Compare
alperozturk96
previously approved these changes
Nov 20, 2023
tobiasKaminsky
force-pushed
the
disabled
branch
from
acd94f3 to
fb2260e
Compare
ZetaTom
previously approved these changes
Nov 21, 2023
alperozturk96
previously approved these changes
Dec 4, 2023
|
/rebase |
nextcloud-command
force-pushed
the
disabled
branch
from
fb2260e to
0681669
Compare
AndyScherzinger
force-pushed
the
disabled
branch
from
0681669 to
17843e1
Compare
library/src/main/java/com/owncloud/android/lib/common/operations/ExceptionParser.java
Outdated
Show resolved
Hide resolved
library/src/main/java/com/owncloud/android/lib/common/operations/ExceptionParser.java
Outdated
Show resolved
Hide resolved
AndyScherzinger
force-pushed
the
disabled
branch
from
17843e1 to
9c4d46d
Compare
AndyScherzinger
force-pushed
the
disabled
branch
from
9c4d46d to
6e70857
Compare
alperozturk96
force-pushed
the
disabled
branch
from
6e70857 to
353b9f5
Compare
tobiasKaminsky
dismissed stale reviews from alperozturk96 and ZetaTom
via
2428067
tobiasKaminsky
force-pushed
the
disabled
branch
from
353b9f5 to
2428067
Compare
tobiasKaminsky
force-pushed
the
disabled
branch
from
2428067 to
d46ecea
Compare
1 task
1 similar comment
Signed-off-by: tobiasKaminsky <[email protected]>
tobiasKaminsky
force-pushed
the
disabled
branch
from
d46ecea to
71557b9
Compare
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
=============================================
- Coverage 49.05% 22.92% -26.13%
+ Complexity 1029 623 -406
=============================================
Files 215 215
Lines 8087 8182 +95
Branches 1038 1041 +3
=============================================
- Hits 3967 1876 -2091
- Misses 3553 6123 +2570
+ Partials 567 183 -384
|
| @@ -30,6 +30,8 @@ public class ExceptionParser { | |||
| private static final String INVALID_PATH_EXCEPTION_STRING = "OC\\Connector\\Sabre\\Exception\\InvalidPath"; | |||
| private static final String INVALID_PATH_EXCEPTION_UPLOAD_STRING = "OCP\\Files\\InvalidPathException"; | |||
| private static final String VIRUS_EXCEPTION_STRING = "OCA\\DAV\\Connector\\Sabre\\Exception\\UnsupportedMediaType"; | |||
| private static final String USER_DISABLED_MESSAGE = "OC\\User\\LoginException: Account disabled"; | |||
There was a problem hiding this comment.
I don't think we can include the 'Account disabled` part since it gets translated on the backend:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an user account is disabled, previously ResultCode was MAINTENANCE_MODE, now it is USER_DISABLED.
I will create a branch on Files app that is using this.