perf: Replace getById call with getFirstNodeById

[CarlSchwan]

And some other minor cleanup in ViewInfoCache

[cypress]

Activity    Run #3308

Run Properties:   Failed #3308  •  dd90ed5123: perf: Replace getById call with getFirstNodeById

Project	Activity
Branch Review	carl/perf-getbyid
Run status	Failed #3308
Run duration	02m 33s
Commit	dd90ed5123: perf: Replace getById call with getFirstNodeById
Committer	Carl Schwan
View all properties for this run ↗︎

---

Test results
Failures	6
Flaky	0
Pending	1
Skipped	0
Passing	3
View all changes introduced in this branch ↗︎

---

Tests for review

  cypress/e2e/sidebar.cy.ts • 6 failed tests • Run E2E

View Output

Test		Artifacts
Check activity listing in the sidebar > Has creation activity		Test Replay Screenshots
Check activity listing in the sidebar > Has favorite activity		Test Replay Screenshots
Check activity listing in the sidebar > Has share activity		Test Replay Screenshots
Check activity listing in the sidebar > Has rename activity		Test Replay Screenshots
Check activity listing in the sidebar > Has move activity		Test Replay Screenshots
Check activity listing in the sidebar > Has tag activity		Test Replay Screenshots

[miaulalala]

Backport?

[miaulalala]

Linter and PHPUnit are not happy:

There were 3 errors:

1) OCA\Activity\Tests\ViewInfoCacheTest::testGetInfoById with data set #0 ('user', 23, 'path', [], true, 'findInfoById')
PHPUnit\Framework\MockObject\IncompatibleReturnValueException: Method findInfoById may not return value of type string, its declared return type is "array"

/home/runner/work/activity/activity/apps/activity/tests/ViewInfoCacheTest.php:122

2) OCA\Activity\Tests\ViewInfoCacheTest::testGetInfoById with data set #1 ('user', 23, 'path', [['returnCache']], true, 'findInfoById')
PHPUnit\Framework\MockObject\IncompatibleReturnValueException: Method findInfoById may not return value of type string, its declared return type is "array"

/home/runner/work/activity/activity/apps/activity/tests/ViewInfoCacheTest.php:122

3) OCA\Activity\Tests\ViewInfoCacheTest::testGetInfoById with data set #2 ('user', 23, 'path', [['returnCache']], true, 'findInfoById')
PHPUnit\Framework\MockObject\IncompatibleReturnValueException: Method findInfoById may not return value of type string, its declared return type is "array"

/home/runner/work/activity/activity/apps/activity/tests/ViewInfoCacheTest.php:122

[CarlSchwan]

/backport to stable33