feat(next-auth): add legacy flag for v4 compatibility #12825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
ThangHuuVu
requested review from
balazsorban44 and
Copilot
and removed request for
ndom91
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a legacy flag to maintain compatibility with v4 behavior alongside the upcoming v5 release. The changes adjust cookie naming, update OAuth callback behavior, and extend configuration types to support the legacy mode.
- Remove duplicate import statements and restructure type declarations.
- Update cookie naming conventions based on legacy mode.
- Amend OAuth handler to conditionally bypass state and PKCE checks when legacy mode is enabled.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/types.ts | Reorders type imports and adds an optional legacy flag to internal options |
| packages/core/src/lib/utils/cookie.ts | Introduces a legacy flag to modify cookie name prefixes accordingly |
| packages/core/src/lib/init.ts | Passes the legacy configuration to defaultCookies and opts in legacy behavior |
| packages/core/src/lib/actions/callback/oauth/callback.ts | Updates OAuth callback to adjust state validation and PKCE handling for legacy mode |
| packages/core/src/index.ts | Adds a legacy flag to AuthConfig to enable legacy mode |
Files not reviewed (1)
- docs/pages/getting-started/migrating-to-v5.mdx: Language not supported
Comments suppressed due to low confidence (1)
packages/core/src/lib/actions/callback/oauth/callback.ts:134
- [nitpick] Consider refactoring the nested ternary logic for 'stateCheck' into a clearer if/else structure or extracting it into a helper function to improve readability and maintainability.
const stateCheck = legacy && !provider.checks.includes("state") ? o.skipStateCheck : provider.checks.includes("state") ? state : o.skipStateCheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
🧢 Checklist
🎫 Affected issues
📌 Resources