[Spring Data JPA] 이예진 미션 제출합니다 #191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokjin8678
suggested changes
Aug 31, 2025
| public ResponseEntity<Void> login( | ||
| @RequestBody LoginRequest loginRequest | ||
| ) { | ||
| ) throws NotFoundException { |
There was a problem hiding this comment.
NotFoundException은 언체크 예외인데, 메서드에 명시적으로 적어주신 이유가 있을까요?
Comment on lines
+21
to
+26
| public static String getStatus(Reservation reservation, Integer rank) { | ||
| if (reservation.isWaiting()) { | ||
| return rank + "번째 예약대기"; | ||
| } | ||
| return "예약"; | ||
| } |
There was a problem hiding this comment.
DTO의 메서드에 접근자가 public인 정적 메서드가 있는 이유가 있을까요?
Comment on lines
+15
to
+16
| @Query("SELECT r FROM Reservation r JOIN FETCH r.theme JOIN FETCH r.time WHERE r.member.id = :memberId") | ||
| List<Reservation> findByMemberIdWithThemeAndTime(@Param("memberId") Long memberId); |
There was a problem hiding this comment.
N+1 문제를 해결하기 위해 FetchJoin을 사용해 주셨네요!
지금은 연관 관계를 맺은 Theme와 Time이 @ManyToOne 관계를 가지고 있어서, 2개 이상 FetchJoin을 해도 문제가 발생하지 않는데, 만약 이 둘이 @OneToMany 관계였다면 어떤 문제가 발생했을까요?
이러한 문제는 어떤 방법으로 해결할 수 있을까요?
Comment on lines
+54
to
+64
| public void cancel(Long id) { | ||
| Reservation reservation = reservationRepository.findById(id) | ||
| .orElseThrow(() -> new IllegalArgumentException( | ||
| "not found reservation with id:" + id)); | ||
| boolean wasReserved = reservation.isReserved(); | ||
|
|
||
| reservationRepository.deleteById(id); | ||
|
|
||
| if (wasReserved) { | ||
| promoteWaitingToReserved(reservation); | ||
| } |
There was a problem hiding this comment.
reservationRepository.deleteById(id)뒤 예외가 발생하면 어떤 문제가 발생하나요?promoteWaitingToReserved(reservation)는Reservation의 상태를 변경하는 메서드 같네요. 하지만 상태 변경이 DB까지 전파되나요?
이러한 문제를 해결하려면 어떤게 필요할까요?
Comment on lines
67
to
+76
| public List<ReservationResponse> findAll() { | ||
| return reservationDao.findAll().stream() | ||
| .map(it -> new ReservationResponse(it.getId(), it.getName(), it.getTheme().getName(), it.getDate(), it.getTime().getValue())) | ||
| .toList(); | ||
| return reservationRepository.findAll().stream() | ||
| .map(it -> new ReservationResponse( | ||
| it.getId(), | ||
| it.getName(), | ||
| it.getTheme().getName(), | ||
| it.getDate(), | ||
| it.getTime().getValue() | ||
| )).toList(); | ||
| } |
There was a problem hiding this comment.
해당 메서드를 실행하면 어떤 예외가 발생하나요?
그렇다면 왜 예외가 발생할까요?
만약 예외가 발생하지 않고, DB에 저장된 Reservation의 개수가 10개라 가정했을 때, reservationRepository.findAll()에서 발생하는 쿼리를 포함한 쿼리는 총 몇 번 발생할까요?
Comment on lines
-17
to
+33
| public LoginService(MemberDao memberDao, JwtUtil jwtUtil) { | ||
| this.memberDao = memberDao; | ||
| public LoginService(MemberRepository memberRepository, JwtUtil jwtUtil) { | ||
| this.memberRepository = memberRepository; | ||
| this.jwtUtil = jwtUtil; | ||
| } | ||
|
|
||
| public String login(String email, String password) { | ||
| Member member = memberDao.findByEmailAndPassword(email, password); | ||
| Member member = memberRepository.findByEmailAndPassword(email, password) | ||
| .orElseThrow( | ||
| () -> new IllegalArgumentException("not found Member with email: " + email)); | ||
| return jwtUtil.createToken(member); | ||
| } | ||
|
|
||
| public MemberInfo check(String token) { | ||
| JwtPayload payload = jwtUtil.parseToken(token); | ||
| Member member = memberDao.findByName(payload.name()); | ||
| Member member = memberRepository.findByName(payload.name()) | ||
| .orElseThrow(() -> new IllegalArgumentException( | ||
| "not found Member with name: " + payload.name())); |
Comment on lines
+33
to
+35
| @ManyToOne(fetch = FetchType.LAZY) | ||
| @JoinColumn(name = "member_id") | ||
| private Member member; |
Comment on lines
+58
to
+68
| public boolean isReserved() { | ||
| return this.status == ReservationStatus.RESERVED; | ||
| } | ||
|
|
||
| public boolean isWaiting() { | ||
| return this.status == ReservationStatus.WAITING; | ||
| } | ||
|
|
||
| public void promoteToReserved() { | ||
| this.status = ReservationStatus.RESERVED; | ||
| } |
There was a problem hiding this comment.
상태를 직접 노출하지 않고, 명확한 이름으로 의미를 잘 전달하는군요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
글렌 안녕하세요 이번에도 잘 부탁드립니다!
이번 미션을 통해서 JPA는 물론이고 심화된 요구사항을 통해서
요구사항 및 전체적인 흐름에 대해 파악하는 능력을 길러야겠단 생각이 들었습니다 ^>^;;
6단계 미션을 진행하면서 제시된 사항과 약간 다르게 진행했는데
(Waiting이 Reservation은 성격이 비슷하여 분리하지 않아도 될 것같단 생각에 하나의 기능으로 개발했습니다)
그러면서 정상 동작을 위해 화면단 변화도 필요했고 요구사항에도 맞지 않는단 생각이 들었어요.
오히려 복잡하게 돌아가면서 시간을 많이 소비하기도 했고, 부족한 부분이 많을 것 같아 아쥬 가감없이 리뷰해주시면 감사하겠습니다..!!
🥹👍