2단계 - 문자열 덧셈 계산기 #5925
Merged
2단계 - 문자열 덧셈 계산기 #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskangg
approved these changes
Mar 14, 2025
Comment on lines
+11
to
+12
| private static final String DEFAULT_DELIMITER = "[,:]"; | ||
| private static final String DELIMITER_FIND_REGEX = "//(.)\n(.*)"; |
| if (StringUtils.isNumeric(input)) { | ||
| return List.of(Integer.parseInt(input)); | ||
| } | ||
| Pattern pattern = Pattern.compile(DELIMITER_FIND_REGEX); |
There was a problem hiding this comment.
Pattern.compile 은 상수화 하는것도 좋을것 같아요!
구현체를 살펴보면 매번 새로운 Pattern 을 생성하기 때문이에요 🙃
/**
* Compiles the given regular expression into a pattern.
*
* @param regex
* The expression to be compiled
* @return the given regular expression compiled into a pattern
* @throws PatternSyntaxException
* If the expression's syntax is invalid
*/
public static Pattern compile(String regex) {
return new Pattern(regex, 0);
}
Comment on lines
+28
to
+30
| } else { | ||
| values = input.split(DEFAULT_DELIMITER); | ||
| } |
There was a problem hiding this comment.
📖 객체지향 생활 체조 원칙
규칙 2: else 예약어를 쓰지 않는다.
를 지켜서 해보는것도 좋을것 같아요! :)
| private final static NumberSeparator numberSeparator = new NumberSeparator(); | ||
|
|
||
|
|
||
| public static int splitAndSum(String o) { |
Comment on lines
+43
to
+53
| @Test | ||
| public void splitAndSum_negative() throws Exception { | ||
| assertThatThrownBy(() -> StringAddCalculator.splitAndSum("-1,2,3")) | ||
| .isInstanceOf(RuntimeException.class); | ||
| } | ||
|
|
||
| @Test | ||
| public void splitAndSum_문자포함() throws Exception { | ||
| assertThatThrownBy(() -> StringAddCalculator.splitAndSum("1,2,test")) | ||
| .isInstanceOf(RuntimeException.class); | ||
| } |
Comment on lines
+5
to
+6
| public StringUtils() { | ||
| } |
There was a problem hiding this comment.
static 메서드만 갖고 있는 클래스의 기본생성자를 열어두셨네요.
이유를 알 수 있을까요? 🤔
Comment on lines
+46
to
+51
| } catch (NumberFormatException e) { | ||
| throw new RuntimeException("숫자가 아닌 값이 입력되었습니다."); | ||
| } | ||
| if (value < 0) { | ||
| throw new RuntimeException("음수는 입력할 수 없습니다."); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기능 요구사항