2단계 - 문자열 덧셈 계산기 #5924
Open
2단계 - 문자열 덧셈 계산기 #5924
+203
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testrace
requested changes
Mar 14, 2025
| @@ -0,0 +1,42 @@ | |||
| package study.step2; | |||
There was a problem hiding this comment.
패키지명은 넘버링보다 기능명으로 작성하면 좋을 것 같아요.
|
|
||
| public class StringAddCalculator { | ||
|
|
||
| public static int splitAndSum(String text) { |
There was a problem hiding this comment.
프로그래밍 요구사항
메소드가 너무 많은 일을 하지 않도록 분리하기 위해 노력해 본다.
를 지키기 위해 메서드를 분리해 보시면 좋을 것 같아요.
Comment on lines
+15
to
+16
| if (text.startsWith("//")) { | ||
| Matcher m = Pattern.compile("//(.)\n(.*)").matcher(text); |
There was a problem hiding this comment.
변경되지 않는 문자열이나 패턴 객체는 상수로 선언해 이름을 부여하면 어떨까요?
Comment on lines
+30
to
+37
| try { | ||
| number = Integer.parseInt(token); | ||
| } catch (NumberFormatException e) { | ||
| throw new RuntimeException("숫자가 아닌 값이 포함되어 있습니다: " + token); | ||
| } | ||
| if (number < 0) { | ||
| throw new RuntimeException("음수는 허용되지 않습니다: " + number); | ||
| } |
There was a problem hiding this comment.
문자열을 분리하기 전에 유효성을 먼저 검증하면 어떨까요?
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
|
||
| public class SetTest { |
There was a problem hiding this comment.
피드백이 반영되지 않은 커밋이 그대로 남아 있네요.
온라인 코드 요청 3단계 가이드 문서를 참고해서 rebase 후 피드백 반영도 함께 해주시면 좋을 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.