2단계 - 문자열 덧셈 계산기 #5921
Merged
2단계 - 문자열 덧셈 계산기 #5921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooobo
approved these changes
Mar 13, 2025
| if (!INTEGER_PATTERN.matcher(str).matches()) { | ||
| throw new RuntimeException("숫자만 입력가능하지만 입력받은 문자열은 " + str + "입니다!"); | ||
| } | ||
| if (Integer.parseInt(str) <= 0) { |
There was a problem hiding this comment.
Number같은 클래스가 있다면 해당 조건들을 지켜주는 온전한 객체를 만들어 볼수있겠네요!
| return result; | ||
| } | ||
|
|
||
| public static int splitAndSum(String input) { |
There was a problem hiding this comment.
한 메서드는 한 가지 일만 해야 한다.
다소 많은 기능으르 수행하고있는데 더 작은 단위로 분리할수 없을지 고민해보면 좋겠네요!
Comment on lines
+10
to
+14
| int result = StringAddCalculator.splitAndSum(null); | ||
| assertThat(result).isEqualTo(0); | ||
|
|
||
| result = StringAddCalculator.splitAndSum(""); | ||
| assertThat(result).isEqualTo(0); |
There was a problem hiding this comment.
Suggested change
| int result = StringAddCalculator.splitAndSum(null); | |
| assertThat(result).isEqualTo(0); | |
| result = StringAddCalculator.splitAndSum(""); | |
| assertThat(result).isEqualTo(0); | |
| assertThat(StringAddCalculator.splitAndSum(null)).isEqualTo(0); | |
| assertThat(StringAddCalculator.splitAndSum("")).isEqualTo(0); |
- 변수명을 재활용하면 추후 유지보수할때 혼란을 야기시킬수 있는 포인트가 될수도 있다고 생각합니다~
- 좀 더 명확한 테스트 코드를 고민해보아요~
- assertAll을 사용해도 좋겠네요~
- @NullAndEmptySource 활용해볼수도 있겠네요!
| @@ -0,0 +1,58 @@ | |||
| package calculator; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.