2단계-문자열 덧셈 계산기 #5909
Merged
2단계-문자열 덧셈 계산기 #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared-moon
requested changes
Mar 12, 2025
| } | ||
|
|
||
| if (isNumber(text)) { | ||
| return Integer.parseInt(text); |
There was a problem hiding this comment.
숫자 하나만 있는 경우는 getSplitSum에서 숫자로 반환될거라 굳이 분기를 안해도 되지 않을까요 ?
| return sum; | ||
| } | ||
|
|
||
| static private int getSingleNumber(String text) throws RuntimeException { |
There was a problem hiding this comment.
checked exception과 unchecked exception은 어떤 차이가 있을까요 ?
There was a problem hiding this comment.
❓기능 요구사항중 6번째에 "음수를 전달할 경우 RuntimeException 예외가 발생해야 한다."라고 되어 있어서, RunetimeException을 던진건데 혹시 제가 잘못 이해한 걸까요?
There was a problem hiding this comment.
아뇨 ~ 질문의 의도는 RuntimeException을 throws 한 이유가 있는지에 대한거였습니다!
| static private int sumStringToken(String[] tokens) throws RuntimeException { | ||
| int sum = 0; | ||
|
|
||
| for(String token: tokens) { |
| return Integer.parseInt(text); | ||
| } | ||
|
|
||
| if (text.startsWith("//")) { |
There was a problem hiding this comment.
이 조건은 getCustomDelimiterSum 안에서도 다시 하고있는 것 같은데, 지금 이 스코프의 분기를 34번 라인 조건에서 해보는 건 어떨까요 ?
| } | ||
|
|
||
| static private int getSplitSum(String text) throws RuntimeException { | ||
| String[] tokens = text.split(",|:"); |
| assertThat(result).isEqualTo(0); | ||
|
|
||
| result = StringAddCalculator.splitAndSum(""); | ||
| assertThat(result).isEqualTo(0); |
There was a problem hiding this comment.
위와 아래가 엄밀하게는 다른 인풋에 대한 테스트라 @ParameterizedTest를 이용해보면 좋을 것 같아요 ~
shared-moon
approved these changes
Mar 13, 2025
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class StringAddCalculator { | ||
| private static final String DELIM = ",|:"; |
| sum += getSingleNumber(token); | ||
| } | ||
| return sum; | ||
| return Arrays.stream(tokens) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2단계-문자열 덧셈 계산기 코드에 대한 PR 리뷰를 요청합니다.