feat: StringAddCalculator 추가 #5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskangg
requested changes
Mar 12, 2025
Comment on lines
5
to
25
| static int splitAndSum(String text) { | ||
| if (text == null || text.isEmpty()) { | ||
| return 0; | ||
| } | ||
|
|
||
| Matcher m = Pattern.compile("//(.)\n(.*)").matcher(text); | ||
| if (m.find()) { | ||
| String customDelimiter = m.group(1); | ||
| String[] numbers = m.group(2).split(customDelimiter); | ||
| return sumNumbers(numbers); | ||
| } else { | ||
| try { | ||
| int number = Integer.parseInt(text); | ||
| if (number < 0) | ||
| throw new RuntimeException(); | ||
| } catch (NumberFormatException ignored) {} | ||
|
|
||
| String[] numbers = text.split("[,:]"); | ||
| return sumNumbers(numbers); | ||
| } | ||
| } |
There was a problem hiding this comment.
메소드가 너무 많은 일을 하지 않도록 분리하기 위해 노력해 본다. 의 요구사항을 지키기 위해 메서드를 분리해보는건 어떨까요? 🤔
String[] 문자열_구분자로_분할()
int[] 문자열에서_숫자변환()
int 숫자전부더하기()크게 위와 같이 기능을 분리할 수 있을것 같아요!
There was a problem hiding this comment.
큰 차이가 있을까 싶었는데 말씀하신 것처럼 분리하니까 훨씬 깔끔하네요! 감사합니다.
혹시 더 개선할 부분이 있으면 말씀해주세요.
| return 0; | ||
| } | ||
|
|
||
| Matcher m = Pattern.compile("//(.)\n(.*)").matcher(text); |
There was a problem hiding this comment.
Pattern.compile("//(.)\n(.*)") 은 상수화 하는것도 좋을것 같아요!
구현체를 살펴보면 매번 새로운 Pattern 을 생성하기 때문이에요 🙃
/**
* Compiles the given regular expression into a pattern.
*
* @param regex
* The expression to be compiled
* @return the given regular expression compiled into a pattern
* @throws PatternSyntaxException
* If the expression's syntax is invalid
*/
public static Pattern compile(String regex) {
return new Pattern(regex, 0);
}
mskangg
approved these changes
Mar 14, 2025
Comment on lines
+11
to
+13
| String[] tokens = splitText(text); | ||
| int[] numbers = convertStringToIntList(tokens); | ||
| return sumNumbers(numbers); |
| import java.util.regex.Pattern; | ||
|
|
||
| public class StringAddCalculator { | ||
| private static final Pattern pattern = Pattern.compile("//(.)\n(.*)"); |
| if (m.find()) { | ||
| return m.group(2).split(m.group(1)); | ||
| } | ||
| return text.split("[,:]"); |
Comment on lines
+40
to
+50
| @Test | ||
| public void splitAndSum_negative() throws Exception { | ||
| assertThatThrownBy(() -> StringAddCalculator.splitAndSum("-1,2,3")) | ||
| .isInstanceOf(RuntimeException.class); | ||
| } | ||
|
|
||
| @Test | ||
| public void splitAndSum_custom_구분자_negative() throws Exception { | ||
| assertThatThrownBy(() -> StringAddCalculator.splitAndSum("//;\n-1;2;3")) | ||
| .isInstanceOf(RuntimeException.class); | ||
| } |
There was a problem hiding this comment.
문자열 계산기에 숫자 이외의 값 또는 음수를 전달하는 경우 RuntimeException 예외를 throw한다.
음수값을 검증하는 테스트코드는 잘 만들어주셨는데, 숫자 이외의 값을 테스트코드가 없네요 😅
TDD 과정이니 요구사항을 만족하는 테스트코드를 먼저 작성한뒤 기능을 구현해보시는것 추천드립니다! :)
There was a problem hiding this comment.
앗 그러네요; 다음 단계에선 더 신경써보겠습니다. 감사합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://edu.nextstep.camp/s/Ie5Dwep0/ls/oD18sXzO