Step2 : 문자열 덧셈 계산기 #5900
Merged
Step2 : 문자열 덧셈 계산기 #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared-moon
approved these changes
Mar 13, 2025
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class ParsedInput { |
There was a problem hiding this comment.
클래스명은 InputParser 이런 느낌으로 명사로 끝나면 좋을 것 같아요!
| import java.util.regex.Pattern; | ||
|
|
||
| public class ParsedInput { | ||
| private static final String DEFAULT_DELIMITER = ",|:"; |
| private String delimiter = DEFAULT_DELIMITER; | ||
| private String[] numbers; | ||
|
|
||
| public ParsedInput(String input) { |
There was a problem hiding this comment.
굳이 상태를 가지고 있을 필요가 없어보이는데, 유틸클래스로 만들어보는 건 어떨까요 ?
| } | ||
|
|
||
| private void parseInput(String input) { | ||
| Pattern pattern = Pattern.compile("//(.)\\n(.*)"); |
| return 0; | ||
| } | ||
|
|
||
| return sumParsedNumbers(new ParsedInput(input).getNumbers()); |
There was a problem hiding this comment.
- 주신 피드백이 혹시 아래 처럼 지역변수로 빼는게 좋을 것 같다는 말씀이신걸까요?
ParsedInput parsedInput = new ParsedInput(input);
return sumParsedNumbers(parsedInput.getNumbers());- 위 처럼 변경하는게 주신 피드백을 제대로 이해한게 맞다면, 위의 코드 처럼 수정 했을 때 장점은 메소드 호출 시 넘기는 인자가 어떤 값인지 변수명으로 명확하게 확인이 된다는 점이라고 생각하는데, 이게 맞을까요?!
| private static int sumParsedNumbers(String[] numbers) { | ||
| int total = 0; | ||
|
|
||
| for (String number : numbers) { |
| int result = StringAddCalculator.splitAndSum(null); | ||
| assertThat(result).isEqualTo(0); | ||
|
|
||
| result = StringAddCalculator.splitAndSum(""); |
There was a problem hiding this comment.
이 두개는 다른 인풋에 대한 테스트라 @ParameterizedTest 를 이용해보면 어떨까요 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.